Remove canSetPolicy, canUpdatePolicy, and canRemovePolicy #33037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now store a pre-compiled list of steps for an index's phase in the `PolicyStepsRegistry`, we no longer need to worry about updating policies as any updates won't affect the current phase, and will only be picked up on phase transitions. This also removes the tests that test these methods Relates to elastic#29823
dakrone
added
the
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-infra |
dakrone
changed the title
colings86
reviewed
Aug 22, 2018
| if (currentStepKey != null) { | ||
| // Check if current step exists in new policy and if not move to | ||
| // next available step | ||
| StepKey nextValidStepKey = newPolicy.getNextValidStep(currentStepKey); |
There was a problem hiding this comment.
I thinks the getNextValidStep() stuff can go to no?
There was a problem hiding this comment.
Can I do that as a followup? I think this change ended up larger than I hoped due to having to change a lot of tests
dakrone
added a commit
that referenced
this pull request
Aug 23, 2018
* Remove canSetPolicy, canUpdatePolicy and canRemovePolicy Since we now store a pre-compiled list of steps for an index's phase in the `PolicyStepsRegistry`, we no longer need to worry about updating policies as any updates won't affect the current phase, and will only be picked up on phase transitions. This also removes the tests that test these methods Relates to #29823
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now store a pre-compiled list of steps for an index's phase in the
PolicyStepsRegistry, we no longer need to worry about updating policies as anyupdates won't affect the current phase, and will only be picked up on phase
transitions.
This also removes the tests that test these methods
Relates to #29823