Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove "platinum" references for Docker TLS #35890

Merged
merged 2 commits into from Nov 29, 2018
Merged

[DOCS] Remove "platinum" references for Docker TLS #35890

merged 2 commits into from Nov 29, 2018

Conversation

jarpy
Copy link
Contributor

@jarpy jarpy commented Nov 26, 2018

These docs explicitly reference Docker images with a -platinum suffix
but they do not exist for current versions of Elasticsearch.

Fixes #7918

These docs explicitly reference Docker images with a `-platinum` suffix
but they do not exist for current versions of Elasticsearch.

Fixes #7918
@jarpy jarpy requested a review from lcawl November 26, 2018 04:28
@colings86 colings86 added >docs General docs changes :Security/TLS SSL/TLS, Certificates labels Nov 26, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@lcawl
Copy link
Contributor

lcawl commented Nov 26, 2018

https://github.com/elastic/elasticsearch/blob/master/docs/reference/setup/install/docker.asciidoc uses the {docker-image} attribute, so it might be a good idea to do that here too in case the path changes again.

@jarpy
Copy link
Contributor Author

jarpy commented Nov 27, 2018

That's a much better idea. Thanks.

Fixed in 40aa198.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Built successfully

@javanna
Copy link
Member

javanna commented Nov 29, 2018

hi @lcawl are you going to merge this? Let me know if there's anything I can do to help. I just relabeled this PR adding also 6.6.0 and 7.0.0. Not sure how far back we have to backport it.

@lcawl
Copy link
Contributor

lcawl commented Nov 29, 2018

Sure, I can do the backports too.

@lcawl lcawl merged commit 8006068 into elastic:master Nov 29, 2018
@javanna
Copy link
Member

javanna commented Nov 29, 2018

Great thanks a lot!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants