[Analysis] Deprecate standard html analyzer in 6.x #37292
Conversation
|
Pinging @elastic/es-search |
johtani
force-pushed
the
remove_standard_html_analyzer_in_6x
branch
2 times, most recently
from
b4a9850
to
76f6f09
Compare
| @@ -136,6 +136,11 @@ public Analyzer getAnalyzer(String analyzer) throws IOException { | |||
| throw new ElasticsearchException("failed to load analyzer for name " + key, ex); | |||
| }} | |||
| ); | |||
There was a problem hiding this comment.
Do we need this part? I think just having the deprecation message in the AnalyzerProvider should be enough?
There was a problem hiding this comment.
I think this part for this line.
If Es find
standard_html_strip from prebuiltAnalysis, Es doesn't use StandardHtmlStripAnalyzerProvider.
There was a problem hiding this comment.
Ah, ok. Can you move the deprecation message into the PreBuiltAnalyzerProviderFactory? Like
I'd rather not have specific analyzers referred to in the AnalysisRegistry if we can avoid it.
There was a problem hiding this comment.
Ah, I pushed it but it failed.
I think the timing to call create function is different between PreBuiltAnalyzerProviderFactory and PreConfiguredTokenFilter.
And I just remembered why I added check logic in AnalysisRegistry...
There was a problem hiding this comment.
@romseygeek Thanks! I will revert last commit, then will merge it.
johtani
force-pushed
the
remove_standard_html_analyzer_in_6x
branch
from
a86619a
to
76f6f09
Compare
|
@elasticmachine test this please |
1 similar comment
|
@elasticmachine test this please |
johtani
force-pushed
the
remove_standard_html_analyzer_in_6x
branch
from
76f6f09
to
e942d63
Compare
Backport elastic#26719 to 6.x Closes elastic#4704 (cherry picked from commit 38b698d)
johtani
force-pushed
the
remove_standard_html_analyzer_in_6x
branch
from
e942d63
to
9828dd0
Compare
Deprecate standard_html_strip analyzer in 6.x
Related #4704