Post filter phrase suggestions #4072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation has a bunch of problems that'll need to be worked before it is a valid candidate for merging. I don't have time to rebase it right now but would still love the feedback on problem. The ones I remember: 1. It performs the filtering by blocking the suggesting thread. 2. Because there is no "exists" query type it uses a limit. I now know that isn't ass efficient as just using a count but it might be worth implementing an exists query type for it any way. 3. It feels like there are a lot of plumbing changes required for this feature. My guess is that is because I'm going about it wrong. This correlates with #1 pretty well. 4. I have to wrap the filter through the map nodes and parse it during the reduce step. That feels silly. Closes elastic#3482
|
Hi nik9000, did you ever sold this problem? |
|
I mostly solved it by splitting my index in half and only query which half I need to at query time. So suggestions are only made on the half that you query. You can still get suggestions for missing results but its much much much less likely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation has a bunch of problems that'll need to be worked
before it is a valid candidate for merging. I don't have time to rebase
it right now but would still love the feedback on problem. The ones I
remember:
that isn't ass efficient as just using a count but it might be worth
implementing an exists query type for it any way.
feature. My guess is that is because I'm going about it wrong. This
correlates with Query DSL: Terms Filter #1 pretty well.
the reduce step. That feels silly.
Closes #3482