Refactored open/close index api to make use of the new recently introduced generic ack mechanism #4170
Conversation
ghost
assigned 
| /** | ||
| * Cluster state update request that allows to close one or more indices | ||
| */ | ||
| public class CloseIndexClusterStateUpdateRequest extends ClusterStateUpdateRequest<CloseIndexClusterStateUpdateRequest> { |
There was a problem hiding this comment.
This class looks exactly the same as the OpenIndexClusterStateUpdateRequest, maybe we can simplify this and factor it out. Seems like it's common?
There was a problem hiding this comment.
Yep we can do that. The only reason why I didn't do it was because usually these classes that extend ClusterStateUpdateRequest can only be created in the same package, and open and close are two different packages... thoughts?
There was a problem hiding this comment.
I think having the classes is fine they can just be marker classes?
|
this PR looks good to me but I still need to understand why |
|
Thanks for the review! The change is similar to what I did in #4115 for aliases. We can backport it as well as explained there. Those custom notifications sent back to the master may be sent to a non existing endpoint during a rolling upgrade, and that wouldn't cause any trouble as exception sent back from the master are literally ignored in that case (see |
|
The updates LGTM +1 to push |
…duced generic ack mechanism Closes elastic#4169
…ed methods variation without version as parameter, to be used by api that always read and write those parameters. Helps avoiding to call the variation that accepts a Version with actual version null.
Refactored open/close index api to make use of the new recently introduced generic ack mechanism
Closes #4169