Added execution option to range filter and deprecated numeric_range filter.
#4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data` as values. Deprecated `numeric_range` filter in favor for the `range` filter with `fielddata` as execution. Closes elastic#4034
| } | ||
|
|
||
| Filter filter = null; | ||
| MapperService.SmartNameFieldMappers smartNameFieldMappers = parseContext.smartFieldMappers(fieldName); | ||
| if (smartNameFieldMappers != null) { | ||
| if (smartNameFieldMappers.hasMapper()) { | ||
| filter = smartNameFieldMappers.mapper().rangeFilter(from, to, includeLower, includeUpper, parseContext); | ||
| if (execution.equals("index")) { | ||
| if (cache == null) { |
There was a problem hiding this comment.
cache flag might come after / before execution, so you might be setting the flag when it has been set by the user..., I would check it after the parsing
There was a problem hiding this comment.
strike that, it looks good, confused by the changes view on github...
|
looks good to me, I would say we can push it to 0.90 as well.... |
|
Makes sense since it only deprecates the |
ghost
assigned
|
pushed to master and 0.90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4034