Query String caching could cause matched_filters not working #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Looks good, the bug is indeed related to caching, so it would be great if the pull request title and comment would reflect that. Also, because its relating to caching, we can simply test for it. For example, index the docs, and execute the search requests with preference set to _primary, and execute it a couple of times, the second one should kick in the caching, and the bug. |
When searching with a query containing query_strings inside a bool query, the specified _name is randomly missing from the results due to caching. Closes elastic#4361. Closes elastic#4371.
|
@kimchy PR updated. You're right. Using _primary cause it failing at every run before the patch. |
|
look good, I would imply instead of duplicating the code, run it in a for loop and do it a couple of times? |
|
@kimchy done and pushed. Thanks for the review. |
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
When searching with a query containing query_strings inside a bool query, the specified _name is randomly missing from the results due to caching. Closes elastic#4361. Closes elastic#4371.
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Thanks @simonw for the review. Related to elastic#4361 and elastic#4371.
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Thanks @simonw for the review. Related to elastic#4361 and elastic#4371.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #4361.
When searching with a query containing query_strings inside a bool query, the specified _name is randomly missing from the results due to caching.