Renamed boost name to path #4401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kept name around for bw compatibility Closes elastic#3315
ghost
assigned 
|
I think you also need to change the behaviour of BoostFieldMapper to also support a path instead of just name. |
|
Closing this PR as it turns out this is not only a rename, but also making the document boost work with a path instead of a simple name (that has max depth 1). That said, we are going to deprecate document boost in #4664. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit makes the change in a backwards compatible manner, keeping the name around (Part that will be backported).
Second commit is only for master: removes the boost name and updates the docs accordingly.
Closes #3315