Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MlConfigIndexMappingsFullClusterRestartIT test which verifies that .ml-config index mappings are properly updated during cluster upgrade #44341

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Jul 15, 2019

This PR adds a test which verifies that .ml-config index mappings are properly updated during cluster upgrade from version 7 to 8.
It verifies the existence of data frame analytics mappings which were introduced in 7.3.
Data frame analytics mappings may show up either in:

  • old cluster if old cluster version is on or after 7.3
    or
  • new cluster if old cluster version is before 7.3. This is the branch that really verifies the mappings update logic.

Related to #44263

@przemekwitek przemekwitek added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 v7.3.0 v7.4.0 labels Jul 15, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/2
run elasticsearch-ci/bwc

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/bwc

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your backport, you may have to do some version restrictions (or add handlers for versions before 7.2.0).

…es that .ml-config index mappings are properly updated between versions 6 and 7.
@przemekwitek przemekwitek force-pushed the full-cluster-restart-test-for-mappings branch from eb500c9 to cfb1b7c Compare July 15, 2019 12:42
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit 747ec94 into elastic:master Jul 15, 2019
@przemekwitek przemekwitek deleted the full-cluster-restart-test-for-mappings branch July 15, 2019 18:35
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Jul 15, 2019
…es that .ml-config index mappings are properly updated during cluster upgrade (elastic#44341)
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Jul 15, 2019
…es that .ml-config index mappings are properly updated during cluster upgrade (elastic#44341)
przemekwitek added a commit that referenced this pull request Jul 16, 2019
…verifies that .ml-config index mappings are properly updated during cluster upgrade (#44341) (#44368)
przemekwitek added a commit that referenced this pull request Jul 16, 2019
…verifies that .ml-config index mappings are properly updated during cluster upgrade (#44341) (#44366)
michalperlak pushed a commit to michalperlak/elasticsearch that referenced this pull request Jul 16, 2019
…es that .ml-config index mappings are properly updated during cluster upgrade (elastic#44341)
polyfractal pushed a commit to polyfractal/elasticsearch that referenced this pull request Jul 29, 2019
…es that .ml-config index mappings are properly updated during cluster upgrade (elastic#44341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >test Issues or PRs that are addressing/adding tests v7.3.0 v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants