Accurate GeoDistance Function #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also modiefied the tests. But croping out the pole areas is not the right way in opinion. Also the test still fail in other areas. Since we know the function is sloppy, we can drop the accuracy tests I guess. |
| `plane` (faster). Defaults to `arc`. | ||
| How to compute the distance. Can either be `arc` (better precision), | ||
| `sloppy` (faster but less precise) or `plane` (fastest). Defaults to | ||
| `sloppy`. |
There was a problem hiding this comment.
Should we name it sloppy_arc instead of just sloppy to make it clear that it doesn't ignore the fact that the earth is round like plane?
|
PR looks good to me. I would just vote to change |
* adapt tests * introduced default GeoDistance function * Updated docs closes elastic#4498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4498