Explicit doc_values setting. #4561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once doc values are enabled on a field, they can't be disabled. Close elastic#4560
|
just to get it right - this PR makes sure that you set DV with the mapping and if you don't do so (ie with dynamic mapping) you can't add it later. So you need to make the decision ahead of time and you can't go back, right? |
|
This is correct: decision needs to be made ahead of time and doc values can't be removed from an existing field. Also there are two ways to set them, either explicitely ( |
|
good +1 in that case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once doc values are enabled on a field, they can't be disabled.
Close #4560