Geo Clean Up #4580
Merged
Geo Clean Up #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -293,10 +291,9 @@ public static GeoPoint decode(String geohash) { | |||
| * @param geohash Geohash to deocde | |||
| * @return Array with the latitude at index 0, and longitude at index 1 | |||
There was a problem hiding this comment.
that @return statement seems wrong now
|
@s1monw I worked in your suggestions. Maybe you can have another look. |
|
@s1monw I setup the changes we discussed. So please have another quick look. |
|
@chilling I think it looks good though the only thing that I think we should change to use constants to parse the |
| @@ -149,4 +182,25 @@ public Filter parse(QueryParseContext parseContext) throws IOException, QueryPar | |||
| } | |||
| return filter; | |||
| } | |||
|
|
|||
| private static final boolean matches(String fieldname, String prefix, String suffix) { | |||
There was a problem hiding this comment.
can we have constants for these instead of building them dynamically. I am not sure if it makes a difference perf wise but I think it's more consistent with all the other parsers.
|
I left more comments there are still inconsistencies with |
|
@s1monw I hope I caught them now |
|
LGTM +1 to push to master! Make sure you squash them before you push :) |
============
The default unit for measuring distances is *MILES* in most cases. This commit moves ES
over to the *International System of Units* and make it work on a default which relates
to *METERS* . Also the current structures of the `GeoBoundingBox Filter` changed in
order to define the *Bounding* by setting abitrary corners.
Distances
---------
Since the default unit for measuring distances has changed to a default unit
`DistanceUnit.DEFAULT` relating to *meters*, the **REST API** has changed at the
following places:
* `ScriptDocValues.factorDistance()` returns *meters* instead of *miles*
* `ScriptDocValues.factorDistanceWithDefault()` returns *meters* instead of *miles*
* `ScriptDocValues.arcDistance()` returns *meters* instead of *miles*
one might use `ScriptDocValues.arcDistanceInMiles()`
* `ScriptDocValues.arcDistanceWithDefault()` returns *meters* instead of *miles*
* `ScriptDocValues.distance()` returns *meters* instead of *miles*
one might use `ScriptDocValues.distanceInMiles()`
* `ScriptDocValues.distanceWithDefault()` returns *meters* instead of *miles*
one might use `ScriptDocValues.distanceInMilesWithDefault()`
* `GeoDistanceFilter` default unit changes from *kilometers* to *meters*
* `GeoDistanceRangeFilter` default unit changes from *miles* to *meters*
* `GeoDistanceFacet` default unit changes from *miles* to *meters*
Geo Bounding Box Filter
-----------------------
The naming of the GeoBoundingBoxFilter properties allows to set arbitrary corners
(see elastic#4084) namely `top_right`, `top_left`, `bottom_right` and `bottom_left`. This
change also includes the fields `topRight` and `bottomLeft` Also it is be possible to
set the single values by using just `top`, `bottom`, `left` and `right` parameters.
Closes elastic#4515, elastic#4084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default unit for measuring distances is MILES in most cases. This commit moves ES
over to the International System of Units and make it work on a default which relates
to METERS . Also the current structures of the
GeoBoundingBox Filterchanged inorder to define the Bounding by setting abitrary corners.
Distances
Since the default unit for measuring distances has changed to a default unit
DistanceUnit.DEFAULTrelating to meters, the REST API has changed at thefollowing places:
ScriptDocValues.factorDistance()returns meters instead of milesScriptDocValues.factorDistanceWithDefault()returns meters instead of milesScriptDocValues.arcDistance()returns meters instead of milesone might use
ScriptDocValues.arcDistanceInMiles()ScriptDocValues.arcDistanceWithDefault()returns meters instead of milesScriptDocValues.distance()returns meters instead of milesone might use
ScriptDocValues.distanceInMiles()ScriptDocValues.distanceWithDefault()returns meters instead of milesone might use
ScriptDocValues.distanceInMilesWithDefault()GeoDistanceFilterdefault unit changes from kilometers to metersGeoDistanceRangeFilterdefault unit changes from miles to metersGeoDistanceFacetdefault unit changes from miles to metersGeo Bounding Box Filter
The naming of the GeoBoundingBoxFilter properties allows to set arbitrary corners
(see #4084) namely
top_right,top_left,bottom_rightandbottom_left. Thischange also includes the fields
topRightandbottomLeftAlso it is be possible toset the single values by using just
top,bottom,leftandrightparameters.Closes #4515, #4084