Rename fuzziness/min_similarity to edit_distance #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| `Edit Distance`:: a minimum Levenshtein Distance (`0`, `1`, `2`) `2` edits are the maximum supported distance. | ||
| `Similarity`:: a minimum similarity value between 0 and 1 to set the required similarity | ||
| between the query term and the matching terms. For example, for a similarity | ||
| of `0.5` a term of the same length as the query term is considered similar |
There was a problem hiding this comment.
isn't "of same length" superfluous? When I read the description, I was confused what would happen for terms that have different lengths
|
+1 |
A lot of different API's currently use different names for the same logical parameter. Since lucene moved away from the notion of a `similarity` and now uses an `fuzziness` we should generalize this and encapsulate the generation, parsing and creation of these settings across all queries. This commit adds a new `Fuzziness` class that handles the renaming and generalization in a backwards compatible manner. This commit also added a ParseField class to better support deprecated Query DSL parameters The ParseField class allows specifying parameger that have been deprecated. Those parameters can be more easily tracked and removed in future version. This also allows to run queries in `strict` mode per index to throw exceptions if a query is executed with deprected keys. Closes elastic#4082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of different API's currently use different names for the
same logical parameter. Since lucene moved away from the notion
of a
similarityand now uses anedit distancewe should generalizethis and encapsulate the generation, parsing and creation of these
settings across all queries.
This commit adds a new
EditDistanceclass that handles the renamingand generalization in a backwards compatible manner.
Closes #4082