Added action.destructive_requires_name that controls whether wildcard expressions are allowed for destructive operations.
#4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd expressions and `_all` is allowed to be used for destructive operat Also the delete index api requires always an index to be specified (either concrete index, alias or wildcard expression) Closes elastic#4549 elastic#4481
|
Looks good! |
|
ah damned I commented on the commit not on the PR @martijnvg can you check? :) |
|
@s1monw I checked and I turned the DestructiveOperations into a statefull helper class! |
|
LGTM thanks @martijnvg |
martijnvg
deleted the
api-cleanup/disable-destructive-operatios-on-all-indices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
action.destructive_requires_namethat controls whether wildcard expressions and_allis allowed to be used for destructive operations. Also the delete index api requires always an index to be specified (either concrete index, alias or wildcard expression)Relates to #4549 #4481