Add the ability to retrieve fields from field data using fielddata_fields
#4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| hitContext.hit().fields().put(field.name(), hitField); | ||
| } | ||
| FieldMapper mapper = context.mapperService().smartNameFieldMapper(field.name()); | ||
| mapper.isNumeric(); |
There was a problem hiding this comment.
Whoops yes, good catch. I'll remove this.
|
LGTM |
Adds a new FetchSubPhase, FieldDataFieldsFetchSubPhase, which loads the field data cache for a field and returns an array of values for the field. Also removes `doc['<field>']` and `_source.<field>` workaround no longer needed in field name resolving. Closes elastic#4492
|
Merged to 1.x and master (2.0) |
|
I think we should merge this into |
|
++ on 1.0 |
|
let's do it then... |
|
Pushed to 1.0 in b3060af also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new FetchSubPhase, FieldDataFieldsFetchSubPhase, which loads the
field data cache for a field and returns an array of values for the
field.
Also removes a
doc['<field>']workaround no longer needed in fieldname resolving.
Closes #4492