Add _cat/versions endpoint #4825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to me! |
|
I did rebase this PR on master which now have the plugin version in. I'm still adding information about jvm and elasticsearch here but they are not really plugins... Wondering if it makes sense? |
|
I would still want to get the jvm & es versions in the |
| clusterStateRequest.local(request.paramAsBoolean("local", clusterStateRequest.local())); | ||
| clusterStateRequest.masterNodeTimeout(request.paramAsTime("master_timeout", clusterStateRequest.masterNodeTimeout())); | ||
|
|
||
| client.admin().cluster().state(clusterStateRequest, new ActionListener<ClusterStateResponse>() { |
There was a problem hiding this comment.
try to use AbstractRestResponseActionListener instead of ActionListener the onFailure method is already implemented there
|
Looks cool can you also add a REST test for this feature? |
If we want to have a full picture of versions running in a cluster, we need to add a `_cat/plugins` endpoint. Response could look like: ```sh % curl es2:9200/_cat/plugins?v node component version type url desc es1 mapper-attachments 1.7.0 j Adds the attachment type allowing to parse difference attachment formats es1 lang-javascript 1.4.0 j JavaScript plugin allowing to add javascript scripting support es1 analysis-smartcn 1.9.0 j Smart Chinese analysis support es1 marvel 1.1.0 j/s http://localhost:9200/_plugins/marvel Elasticsearch Management & Monitoring es1 kopf 0.5.3 s http://localhost:9200/_plugins/kopf kopf - simple web administration tool for ElasticSearch es2 mapper-attachments 2.0.0.RC1 j Adds the attachment type allowing to parse difference attachment formats es2 lang-javascript 2.0.0.RC1 j JavaScript plugin allowing to add javascript scripting support es2 analysis-smartcn 2.0.0.RC1 j Smart Chinese analysis support ``` Closes elastic#4824.
|
Closed with f54e924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to have a full picture of versions running in a cluster, we need to add a
_cat/versionsendpoint.Response could look like:
% curl es2:9200/_cat/versions?v node component version es1 jvm 1.6.0_65-b14 es1 elasticsearch 0.90.10 es1 elasticsearch-mapper-attachment 1.7.0 es1 elasticsearch-lang-js 1.7.0 es1 elasticsearch-analysis-smartcn 1.9.0 es2 jvm 1.6.0_65-b14 es2 elasticsearch 1.0.0.RC1 es2 elasticsearch-mapper-attachment 2.0.0.RC1 es2 elasticsearch-lang-js 2.0.0.RC1 es2 elasticsearch-analysis-smartcn 2.0.0.RC1Closes #4824.
Note that this PR requires first #4378 to be merged.