Introducing VersionType.FORCE & VersionType.EXTERNAL_GTE #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added "external_gt" as an alias name for VersionType.EXTERNAL , accessible for the rest layer. Closes elastic#4213 , Closes elastic#2946
…ue where routing value is required and version type is not internal.
| @@ -328,6 +335,7 @@ protected ShardIterator shards(ClusterState clusterState, BulkShardRequest reque | |||
| } | |||
|
|
|||
| assert responses[requestIndex] != null; // we must have set a response somewhere. | |||
| assert preVersionTypes[requestIndex] != null; | |||
There was a problem hiding this comment.
should we move this up and fail earlier?
There was a problem hiding this comment.
My only reason to add it was to make sure that none of the code paths forget to set it. Did it when I found a place that did (DeleteRequest)
|
I think this looks good - I still would want @kimchy to look at it before we push |
|
LGTM! |
|
I don't find this feature in the docs, especially not within the "optimistic concurrency control" documentation where i'd expect it ... is this still alive? |
|
@mrkamel very much alive and described here: http://www.elastic.co/guide/en/elasticsearch/reference/current/docs-index_.html#_version_types |
clintongormley
added
>feature
v1.1.0
v2.0.0-beta1
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added "external_gt" as an alias name for VersionType.EXTERNAL , accessible for the rest layer.
Closes #4213 , Closes #2946