Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix SLM check for restore in progress (#50868) #50876

Merged
merged 2 commits into from Jan 10, 2020

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jan 10, 2020

Backports the following commits to 7.x:

* Fix SLM check for restore in progress

This commit fixes the check in SLM where the `RestoreInProgress`
metadata was checked for existence. Rather than check existence we
should instead check the `isEmpty` method. Prior to this, a successful
restore for a repository that used SLM retention would prevent SLM
retention from running in subsequent invocations, due to SLM thinking
that a restore was still running.
@dakrone dakrone added backport :Data Management/ILM+SLM Index and Snapshot lifecycle management >bug v7.6.0 labels Jan 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@dakrone dakrone merged commit 63472d3 into elastic:7.x Jan 10, 2020
@dakrone dakrone deleted the backport/7.x/pr-50868 branch January 10, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants