Source filtering with wildcards broken when given multiple patterns #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
curl -XPUT 'http://localhost:9200/twitter/tweet/1' -d '{
"user" : "kimchy",
"post_date" : "2009-11-15T14:12:12",
"message" : "trying out Elasticsearch", "retweeted": false
}'
```
No source fields delivered:
```
curl -XGET 'http://localhost:9200/twitter/tweet/1?_source=*.id,retweeted&pretty=yes'
```
`retweeted` returned:
```
curl -XGET 'http://localhost:9200/twitter/tweet/1?_source=retweeted,*.id&pretty=yes'
```
Closes elastic#5132.
| @@ -172,24 +172,24 @@ private static void filter(Map<String, Object> map, Map<String, Object> into, St | |||
| if (include.charAt(0) == '*') { | |||
| if (Regex.simpleMatch(include, path)) { | |||
| exactIncludeMatch = true; | |||
| break; | |||
| continue; | |||
There was a problem hiding this comment.
This can stay as a break - exactInclude is the highest form of checking, no need to check more
|
hey david, thanks for picking it up. Left some comments. Let me know what you think. |
|
Agreed with all comments @bleskes. I applied them. Let me know. |
|
+1! |
dadoonet
added a commit
that referenced
this pull request
Feb 17, 2014
```
curl -XPUT 'http://localhost:9200/twitter/tweet/1' -d '{
"user" : "kimchy",
"post_date" : "2009-11-15T14:12:12",
"message" : "trying out Elasticsearch", "retweeted": false
}'
```
No source fields delivered:
```
curl -XGET 'http://localhost:9200/twitter/tweet/1?_source=*.id,retweeted&pretty=yes'
```
`retweeted` returned:
```
curl -XGET 'http://localhost:9200/twitter/tweet/1?_source=retweeted,*.id&pretty=yes'
```
Closes #5132.
Closes #5133.
(cherry picked from commit 5d15936)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No source fields delivered:
retweetedreturned:Closes #5132.