Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using the FVH and Postings Highlighter without storing extra data #5184

Closed
wants to merge 14 commits into from

Commits on Feb 19, 2014

  1. Configuration menu
    Copy the full SHA
    c9aa517 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    90ac620 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2014

  1. Add caching for source fetching

    Speeds things up especially when you have lots of matched fields that
    share the same indexed field.
    nik9000 committed Feb 20, 2014
    Configuration menu
    Copy the full SHA
    861811e View commit details
    Browse the repository at this point in the history
  2. Replace MemoryIndex with hand built code

    This code lies more then memory index but it is faster and doesn't lie
    enough to break the FVH.
    
    Also add term filtering to the analysis which saves a ton of time.
    nik9000 committed Feb 20, 2014
    Configuration menu
    Copy the full SHA
    d93f958 View commit details
    Browse the repository at this point in the history
  3. Cleanup

    nik9000 committed Feb 20, 2014
    Configuration menu
    Copy the full SHA
    b3d4f83 View commit details
    Browse the repository at this point in the history
  4. More cleanup

    nik9000 committed Feb 20, 2014
    Configuration menu
    Copy the full SHA
    8feddf9 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2014

  1. Add support for Postings highlighter

    Nothing fancy for skipping the offsets for short documents like with the
    FVH.
    nik9000 committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    6b886dd View commit details
    Browse the repository at this point in the history
  2. Fix some tests I missed

    nik9000 committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    e5f8358 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18a55e7 View commit details
    Browse the repository at this point in the history
  4. Start integrating with the PageCacheRecycler

    I have no idea if this is faster yet, but it ought to be less gnarly from
    a memory standpoint.
    nik9000 committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    4356bac View commit details
    Browse the repository at this point in the history
  5. Use more of the PageCacheRecycler stuff

    This helps a bunch with memory but isn't perfect.
    
    A few things we could really improve but I don't really feel like it now:
    1.  Rebuild SliceWriter and SliceReader against Elasticsearch's IntArray
    so that we can build a smaller and throw out XIntBlockPool.
    2.  Cache the BytesRefHash between analyses - maybe use it instead of a
    Set<String> for filtering and use the term that spits out the BytesRef
    and the hashcode of the field at the same time.
    nik9000 committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    a80cbd7 View commit details
    Browse the repository at this point in the history
  6. Remove the lookup caching

    It wasn't helping
    nik9000 committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    2873b61 View commit details
    Browse the repository at this point in the history
  7. Docs

    nik9000 committed Feb 21, 2014
    Configuration menu
    Copy the full SHA
    d6f8232 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2014

  1. Stop supporting term vectors only on long fields

    We'll add this back in another pull request.
    nik9000 committed Mar 5, 2014
    Configuration menu
    Copy the full SHA
    63babf1 View commit details
    Browse the repository at this point in the history