BytesReference usage to properly work when hasArray is not available #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a BytesReference doesn't have a backing array, properly handle the case in places where its applicable
|
LGTM, just make sure to open an issue for the todo in the FsTranslog |
| @@ -341,6 +341,9 @@ protected void parseCreateField(ParseContext context, List<Field> fields) throws | |||
| } | |||
| } | |||
| } | |||
| if (!source.hasArray()) { | |||
| source = source.toBytesArray(); | |||
| } | |||
| assert source.hasArray(); | |||
There was a problem hiding this comment.
does this assert still make sense?
kimchy
added a commit
that referenced
this pull request
Mar 18, 2014
when a BytesReference doesn't have a backing array, properly handle the case in places where its applicable closes #5455
|
@s1monw missed your notes, pushed, sorry!, will fix the additional notes |
|
@kimchy thx |
|
issue for translog added: #5463, and pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a BytesReference doesn't have a backing array, properly handle the case in places where its applicable