Add reverse_nested aggregation
#5507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private final Filter parentFilter; | ||
| private DocIdSetIterator parentDocs; | ||
|
|
||
| // TODO: Should we add LongIntPagedHashMap? |
There was a problem hiding this comment.
I think it would make sense. Since all these paged impls are going to be very similar, I'm wondering how we could auto-generate them (just thinking out loud, this would need to be done in a separate change!)
…the next nested object mapping above the nested field specified in the `nested` agg wrapping the reverse_nested agg. Fail if reverse_nested agg isn't wrapped in a nested agg Rebased with master
|
Rebased and updated the PR:
|
| aggregation can break out of the nested block structure and link to other nested structures or the root document, | ||
| which allows nesting other aggregations that aren't part of the nested object in a nested aggregation. | ||
|
|
||
| For example, lets say we have an index for a ticket system which issues and comments. The commends are inlined into |
Removed automatic path resolving If no path is defined then the reverse_nested agg always joins back to the root / main document level.
|
Updated the PR:
|
|
LGTM |
martijnvg
added a commit
that referenced
this pull request
Apr 30, 2014
The `reverse_nested` aggregation allows to aggregate on properties outside of the nested scope of a `nested` aggregation. Closes #5507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #5485
There a number of todos that need to be addressed.