Allow to disable norms on an existing field. #5511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM this should go 1.2 and 2.0 no? |
|
that was my plan |
| @@ -620,6 +620,7 @@ public void merge(Mapper mergeWith, MergeContext mergeContext) throws MergeMappi | |||
|
|
|||
| if (!mergeContext.mergeFlags().simulate()) { | |||
| // apply changeable values | |||
| this.fieldType = fieldMergeWith.fieldType; | |||
There was a problem hiding this comment.
I'm worried that by copying over the field type completely we get more stuff then what we tested for collisions. For example, indexOptions is not tested. Maybe there are other stuff.
There was a problem hiding this comment.
Good point, I'll make a copy.
|
@bleskes Can you check if the last commit addresses your concerns? Thanks! |
|
@jpountz it does. Thx. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed @nik9000 's idea to carefully document the caveat of disabling
norms as opposed to trying to wrap readers at search time to hide norms.
Close #4813