Add human readable start_time and refresh_interval
#5544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the change! The only thing we need to discuss is that it breaks backwards compatibility, but I don't see a way around it honestly. |
|
I think we can change it. My gut feeling is that this number is hardly monitored/used by programs and changing it will make it consistent with the other time values . |
|
++ on getting this in |
|
Merged, thanks @kzwang and marked the original issue as breaking |
clintongormley
added
>breaking
v2.0.0-beta1
v1.2.0
:Data Management/Stats
clintongormley
changed the title
clintongormley
changed the title
start_time and refresh_interval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5280