Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure successful operations are correct if second search phase is fast #5713

Merged
merged 2 commits into from Apr 7, 2014
Merged

Make sure successful operations are correct if second search phase is fast #5713

merged 2 commits into from Apr 7, 2014

Commits on Apr 7, 2014

  1. Make sure successful operations are correct if second phase is fast 

    In TransportSearchTypeAction we  need to increment successful ops
first before we increment and compare the exit condition otherwise if we
are fast we could concurrently update totalOps but then preempt one
of the threads which can cause the successor to read a wrong value from
successfulOps if second phase is very fast ie. searchType == count etc.
This can cause wrong success stats in the search response.
    @s1monw
    s1monw committed Apr 7, 2014
    Configuration menu
    Copy the full SHA
    befa833 View commit details
    Browse the repository at this point in the history

  2. Rename successulOps to successfulOps in TransportSearchTypeAction

    @s1monw
    s1monw committed Apr 7, 2014
    Configuration menu
    Copy the full SHA
    49c74e0 View commit details
    Browse the repository at this point in the history