Include name of the field that caused a circuit break in the log and exception message #5841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| memoryBytesLimit + "/" + new ByteSizeValue(memoryBytesLimit) + "]"); | ||
| } | ||
|
|
||
| public double addEstimateBytesAndMaybeBreak(long bytes) throws CircuitBreakingException { |
There was a problem hiding this comment.
Should this perhaps be marked @Deprecated or do you foresee a use for n/a fields (e.g., something else like whole documents?)?
If it's meant to allow something that is not a field, then maybe it should be a different message. If it is a field, then I would rather always see the field name.
There was a problem hiding this comment.
I left it for testing simplicity, but it's simple enough to remove and force a field name, done.
|
LGTM you should squash it and push |
…exception message Fixes elastic#5718 Closes elastic#5841
mikemccand
pushed a commit
to mikemccand/elasticsearch
that referenced
this pull request
Apr 24, 2014
…exception message Fixes elastic#5718 Closes elastic#5841
clintongormley
added
the
:Core/Infra/Circuit Breakers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5718
Now the log message looks like:
And the exception on the client side looks like: