Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Create/Update/Delete classes less mutable #5939

Closed
wants to merge 1 commit into from
Closed

Make Create/Update/Delete classes less mutable #5939

wants to merge 1 commit into from

Commits on Apr 25, 2014

  1. Make Create/Update/Delete classes less mutable 

    Today we use a builder pattern / setters to set relevant information
to Engine#Delete|Create|Index. Yet almost all the values are required
but they are not passed via ctor arguments but via an error prone builder
pattern. If we add a required argument we should see compile errors on that
level to make sure we don't miss any place to set them.

Prerequisite for elastic#5917
    @s1monw
    s1monw committed Apr 25, 2014
    Configuration menu
    Copy the full SHA
    019fb4c View commit details
    Browse the repository at this point in the history