New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search might not return on thread pool rejection #6032
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
src/test/java/org/elasticsearch/action/RejectionActionTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.action; | ||
|
|
||
| import com.google.common.collect.Lists; | ||
| import org.elasticsearch.ExceptionsHelper; | ||
| import org.elasticsearch.action.search.SearchPhaseExecutionException; | ||
| import org.elasticsearch.action.search.SearchResponse; | ||
| import org.elasticsearch.action.search.SearchType; | ||
| import org.elasticsearch.action.search.ShardSearchFailure; | ||
| import org.elasticsearch.common.settings.ImmutableSettings; | ||
| import org.elasticsearch.common.settings.Settings; | ||
| import org.elasticsearch.index.query.QueryBuilders; | ||
| import org.elasticsearch.test.ElasticsearchIntegrationTest; | ||
| import org.elasticsearch.test.ElasticsearchIntegrationTest.ClusterScope; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.Locale; | ||
| import java.util.concurrent.CopyOnWriteArrayList; | ||
| import java.util.concurrent.CountDownLatch; | ||
|
|
||
| import static org.hamcrest.Matchers.equalTo; | ||
|
|
||
| /** | ||
| */ | ||
| @ClusterScope(scope = ElasticsearchIntegrationTest.Scope.SUITE, numDataNodes = 2) | ||
| public class RejectionActionTests extends ElasticsearchIntegrationTest { | ||
|
|
||
| @Override | ||
| protected Settings nodeSettings(int nodeOrdinal) { | ||
| return ImmutableSettings.builder() | ||
| .put("threadpool.search.size", 1) | ||
| .put("threadpool.search.queue_size", 1) | ||
| .put("threadpool.index.size", 1) | ||
| .put("threadpool.index.queue_size", 1) | ||
| .put("threadpool.get.size", 1) | ||
| .put("threadpool.get.queue_size", 1) | ||
| .build(); | ||
| } | ||
|
|
||
|
|
||
| @Test | ||
| public void simulateSearchRejectionLoad() throws Throwable { | ||
| for (int i = 0; i < 10; i++) { | ||
| client().prepareIndex("test", "type", Integer.toString(i)).setSource("field", "1").get(); | ||
| } | ||
|
|
||
| int numberOfAsyncOps = randomIntBetween(200, 700); | ||
| final CountDownLatch latch = new CountDownLatch(numberOfAsyncOps); | ||
| final CopyOnWriteArrayList<Object> responses = Lists.newCopyOnWriteArrayList(); | ||
| for (int i = 0; i < numberOfAsyncOps; i++) { | ||
| client().prepareSearch("test") | ||
| .setSearchType(SearchType.QUERY_THEN_FETCH) | ||
| .setQuery(QueryBuilders.matchQuery("field", "1")) | ||
| .execute(new ActionListener<SearchResponse>() { | ||
| @Override | ||
| public void onResponse(SearchResponse searchResponse) { | ||
| responses.add(searchResponse); | ||
| latch.countDown(); | ||
| } | ||
|
|
||
| @Override | ||
| public void onFailure(Throwable e) { | ||
| responses.add(e); | ||
| latch.countDown(); | ||
| } | ||
| }); | ||
| } | ||
| latch.await(); | ||
| assertThat(responses.size(), equalTo(numberOfAsyncOps)); | ||
|
|
||
| // validate all responses | ||
| for (Object response : responses) { | ||
| if (response instanceof SearchResponse) { | ||
| SearchResponse searchResponse = (SearchResponse) response; | ||
| for (ShardSearchFailure failure : searchResponse.getShardFailures()) { | ||
| assertTrue("got unexpected reason..." + failure.reason(), failure.reason().toLowerCase(Locale.ENGLISH).contains("rejected")); | ||
| } | ||
| } else { | ||
| Throwable t = (Throwable) response; | ||
| Throwable unwrap = ExceptionsHelper.unwrapCause(t); | ||
| if (unwrap instanceof SearchPhaseExecutionException) { | ||
| SearchPhaseExecutionException e = (SearchPhaseExecutionException) unwrap; | ||
| for (ShardSearchFailure failure : e.shardFailures()) { | ||
| assertTrue("got unexpected reason..." + failure.reason(), failure.reason().toLowerCase(Locale.ENGLISH).contains("rejected")); | ||
| } | ||
| } else { | ||
| throw new AssertionError("unexpected failure", (Throwable) response); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe put the for loop and onFailure call into a try final block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see a reason where this will require a try .., finally, since the calls to release the context are properly protected. I think its enough?