Pc min should match #6095
Closed
Pc min should match #6095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,274 @@ | |||
| --- | |||
There was a problem hiding this comment.
I think most of these tests should be Java tests? (in SimpleChildQuerySearchTests)
|
@clintongormley can we add a |
|
@dakrone Yeah, I was thinking the same thing. Btw, this PR hasn't stalled - I want to sit down with @martijnvg after 1.2 and see what to do about refactoring. |
|
This PR now includes |
| } | ||
|
|
||
| /** | ||
| * Defines the minimum number of children that are required to match for the parent to be considered a match. |
There was a problem hiding this comment.
This has the same jdocs as minChildren.
ChildrenConstantScoreQuery and ChildrenQuery. Intended only for has_child filter or has_child queries without scoring when minimum_children > 1 is specified.
to support both scoring and counting and the combination
…ndividual classes
… purposes In practice, the HasChild query/filter uses ChildrenConstantScoreQuery instead
|
Lets get this in! LGTM! |
|
I think we can close this one right @clintongormley ? Also the labels are already on the related issue, we might want to remove them from the PR. |
|
Closed by #6019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
minimum_childrenparameter to thehas_childquery and filter.score_mode: sum|avg|max, it was possible to support this directly in ChildrenQuery.score_mode: none, I added CountChildrenConstantScoreQuery as it seemed a cleaner solution than trying to make either ChildrenQuery or ChildrenConstantScoreQuery fitYAML tests have been added, but not sure what to do the Java tests. Also still needs docs.
Closes #6019