Index field names of documents. #6269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `exists` and `missing` filters need to merge postings lists of all existing terms, which can be very costly, especially on high-cardinality fields. This commit indexes the field names of a document under `_field_names` and reuses it to speed up the `exists` and `missing` filters. This is only enabled for indices that are created on or after Elasticsearch 1.3.0. Close elastic#5659
| /** | ||
| * Return the {@link Version} of Elasticsearch that has been used to create an index given its settings. | ||
| */ | ||
| public static Version indexCreated(Settings indexSettings) { |
There was a problem hiding this comment.
oh good! thanks for adding this! I didn't look further down but maybe we can have some basic tests that is does what we expect it to do?
|
I left some comments this will be a nice improvement! |
|
@s1monw I just pushed a new commit and replied to your comments. |
|
left one comment other than that LGTM |
|
I'll fix the test. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
existsandmissingfilters need to merge postings lists of all existingterms, which can be very costly, especially on high-cardinality fields. This
commit indexes the field names of a document under
_field_namesand uses itto speed up the
existsandmissingfilters.This is only enabled for indices that are created on or after Elasticsearch
1.3.0.
Close #5659