Test: Randomly disable the filter cache. #6280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice randomization! LGTM |
|
good stuff! |
jpountz
added a commit
that referenced
this pull request
May 22, 2014
clintongormley
changed the title
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Sep 3, 2014
…cIdSet. A few months ago, Lucene switched from FixedBitSet to WAH8DocIdSet in order to cache filters. WAH8DocIdSet is especially better when dealing with sparse sets: iteration is faster, memory usage is lower and there is an index that helps keep advance fast. This doesn't break existing code since elastic#6280 already made sure that there was no abusive cast from DocIdSet to Bits or FixedBitSet and elastic#7037 moved consumers of the filter cache that absolutely need to get fixed bitsets to their own cache. Since cached filters will be more memory-efficient, the filter cache size has been decreased from 10 to 5%. Although smaller, this might still allow to cache more filters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Randomize all the things"
Relates to #6278 and #6279