Issue with polygons near date line #6282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -192,5 +193,44 @@ public void testLineStringWrapping() { | |||
| assertMultiLineString(shape); | |||
| } | |||
|
|
|||
| public void testDateline() { | |||
There was a problem hiding this comment.
Missing @Test annotation here?
There was a problem hiding this comment.
I think the framework supports both: method names that start with test or @Test annotations.
There was a problem hiding this comment.
Yeah it did seem to be running the test without the annotation but I have added the annotation anyway for consistency
|
LGTM |
|
Merged into master and 1.x but the PR did not automatically close so closing manually |
clintongormley
added
>bug
v2.0.0-beta1
v1.3.0
:Analytics/Geo
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a polygon is constructed which overlaps the date line but has a hole which lies entirely one to one side of the date line, JTS error saying that the hole is not within the bounds of the polygon because the code which splits the polygon either side of the date line does not add the hole to the correct component of the final set of polygons. The fix ensures this selection happens correctly.
Closes #6179