Client intermediate interfaces removal follow-up #6563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM, safety first! |
After elastic#6517 we ended up registering all of the actions (included admin ones) to the NodeClient. Made sure that only the proper type of Action instances are registered to each client type. Also fixed some compiler warnings: unused members, imports and non matching generic types. Closes elastic#6563
clintongormley
changed the title
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #6517 we ended up registering all of the actions (included admin ones) to the NodeClient.
Made sure that only the proper type of
Actioninstances are registered to each client type.Also fixed some compiler warnings: unused members, imports and non matching generic types.