Make ignore_unmapped work for sorting cross-index queries.
#7039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,7 @@ | |||
|
|
|||
| private Object missing; | |||
|
|
|||
| private Boolean ignoreUnmapped; | |||
| private Object ignoreUnmapped; | |||
There was a problem hiding this comment.
Was wondering why this is an Object rather then a String?
There was a problem hiding this comment.
I added a setter with a String parameter but there was already also one with a boolean parameter. So I made the variable an object internally so that it can be either a Boolean or a String.
|
|
| Mapper.Builder<?, ?> builder = typeParser.parse(fieldName, ImmutableMap.<String, Object>of(), parserContext); | ||
| Settings indexSettings = context.indexShard().indexService().settingsService().getSettings(); | ||
| BuilderContext builderContext = new BuilderContext(indexSettings, new ContentPath(1)); | ||
| fieldMapper = (FieldMapper<?>) builder.build(builderContext); |
There was a problem hiding this comment.
can we maybe share these on an index level, instead of doing the whole build process over and over? just a set of static (index level) common types?
|
@areek @markharwood @kimchy Pushed new commits to address your concerns. |
|
LGTM |
This was referenced Aug 1, 2014
This was referenced Nov 29, 2014
clintongormley
added
the
:Search/Search
clintongormley
changed the title
ignore_unmapped work for cross-index queries.ignore_unmapped work for sorting cross-index queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2255