Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored TransportSingleCustomOperationAction, subclasses and requests #7214

Closed
wants to merge 2 commits into from

Commits on Aug 9, 2014

  1. Internal: refactored TransportSingleCustomOperationAction, subclasses…

    … and requests
    
    TransportSingleCustomOperationAction is subclassed by two similar, yet different transport action: TransportAnalyzeAction and TransportGetFieldMappingsAction. Made their difference and similarities more explicit by sharing common code and moving specific code to subclasses:
    - moved index field to the parent SingleCustomOperationAction class
    - moved the common check blocks code to the parent transport action class
    - moved the main transport handler to the TransportAnalyzeAction subclass as it is only used to receive external requests through clients. In the case of the TransportGetFieldMappingsIndexAction instead, the action is internal and executed only locally as part of the user facing TransportGetFieldMappingsAction. The corresponding request gets sent over the transport though as part of the related shard request
    - removed the get field mappings index action from the action names mapping as it is not a transport handler anymore. It was before although never used.
    javanna committed Aug 9, 2014
    Copy the full SHA
    3b7f411 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2014

  1. Copy the full SHA
    6f8fc1a View commit details
    Browse the repository at this point in the history