Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made original indices optional for broadcast delete and delete by query shard requests #7406

Closed
wants to merge 1 commit into from
Closed

Made original indices optional for broadcast delete and delete by query shard requests #7406

wants to merge 1 commit into from

Commits on Aug 22, 2014

  1. Internal: made original indices optional for broadcast delete and del… 

    …ete by query shard requests

Shard requests like broadcast delete and delete by query, that needs to be executed on primary and all replicas, get read and written out to the transport on the same node. That means that if we add some field version checks are not enough to maintain bw comp since a newer node that holds the primary might receive the request from an older node, that didn't provide the field. Yet, when writing the request out again to a newer node that holds the replica, we do try and serialize the field although it's missing. The newer fields just needs to be set to optional in these cases, in addition to the version checks.

Re-enabled testDeleteByQuery and testDeleteRoutingRequired bw comp tests since this was the cause of their failures.
    @javanna
    javanna committed Aug 22, 2014
    Configuration menu
    Copy the full SHA
    ca5d378 View commit details
    Browse the repository at this point in the history