Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use a background thread to disconnect node which are removed from the ClusterState #7543

Closed
wants to merge 3 commits into from
Closed

Do not use a background thread to disconnect node which are removed from the ClusterState #7543

wants to merge 3 commits into from

Commits on Sep 2, 2014

  1. [Internal] verify node is no longer in ClusterState before disconnect… 

    …ing it (after a ping failure)

After a node fails to respond to a ping correctly (master or node fault detection), they are removed from the cluster state through an UpdateTask. When a node is removed, a background task is scheduled using the generic threadpool to actually disconnect the node. However, in the case of temporary node failures (for example) it may be that the node was re-added by the time the task get executed. We should check for that.
    @bleskes
    bleskes committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    4feb602 View commit details
    Browse the repository at this point in the history

  2. remove background execution all together

    @bleskes
    bleskes committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    a483a22 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2014

  1. added try catch around disconnect

    @bleskes
    bleskes committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    593b9d7 View commit details
    Browse the repository at this point in the history