Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure channel closing never happens on i/o thread #7726

Closed
wants to merge 2 commits into from
Closed

Make sure channel closing never happens on i/o thread #7726

wants to merge 2 commits into from

Commits on Sep 15, 2014

  1. Netty: Make sure channel closing never happens on i/o thread 

    Similar to NettyTransport.doStop() all actions which disconnect
from a node (and thus call awaitUnterruptibly) should not be executed
on the I/O thread.

This patch ensures that all disconnects happen in the generic threadpool.

Also added a missing return statement in case the component was not yet
started when catching an exception on the netty layer.
    @spinscale @javanna
    spinscale authored and javanna committed Sep 15, 2014
    Copy the full SHA
    2bea708 View commit details
    Browse the repository at this point in the history

  2. review round

    @javanna
    javanna committed Sep 15, 2014
    Copy the full SHA
    cf05e06 View commit details
    Browse the repository at this point in the history