Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split internal fetch request used within scroll and search #7870

Closed

Commits on Sep 25, 2014

  1. Internal: split internal fetch request used within scroll and search

    Similar to elastic#7856 but relates to the fetch shard level requests. We currently use the same internal request when we need to fetch within search and scroll. The two original requests though diverged after elastic#6933 as SearchRequest implements IndicesRequest while SearchScrollRequest doesn't. That said, with elastic#7319 we made `FetchSearchRequest` implement IndicesRequest by making it hold the original indices taken from the original request, which are null if the fetch was originated by a search scroll, and that is why original indices are optional there.
    
    This commit introduces a separate fetch request and transport action for scroll, which doesn't hold original indices. The new action is only used against nodes that expose it, the previous action name will be used for nodes older than 1.4.0.Beta1.
    
    As a result, in 1.4 we have a new `indices:data/read/search[phase/fetch/id/scroll]` action that is equivalent to the previous `indices:data/read/search[phase/fetch/id]` whose request implements now IndicesRequest and holds the original indices coming from the original request. The original indices in the latter request can only be null during a rolling upgrade (already existing version checks make sure that serialization is bw compatible), when some nodes are still < 1.4.
    javanna committed Sep 25, 2014
    Copy the full SHA
    9cb2064 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2014

  1. review round: renamed FetchRequest to ShardFetchRequest and `Fetc…

    …hSearchRequest` to `ShardFetchSearchRequest`
    javanna committed Sep 26, 2014
    Copy the full SHA
    c4a5caa View commit details
    Browse the repository at this point in the history
  2. added docs

    javanna committed Sep 26, 2014
    Copy the full SHA
    5f92197 View commit details
    Browse the repository at this point in the history