Indexed script fixes #7929
Closed
Indexed script fixes #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a render endpoint to allow rendering of templates.
````
POST /_render/template
'{
"template":
{
"query":
{
"{{foo}}": {}
},
"size": "{{my_{{}}size}}"
},
"params": { "foo": "match_all", "my_size": 10}
}'
````
Will render
````
{
"template" :
{
"query" : {
"match_all" : {}
},
"size" : 10
}
}
````
Closes elastic#6821
Add missing file.
…figurable. This change adds a new resource watcher level of CUSTOM and allows the addition of custom levels of timing. This is used by the ScriptService to register the FileWatcher.
This commit allows the refresh timings for on disk scripts to be dymanically updated. Also adds a test to make sure that new scripts are available at search time.
|
I'm updating the docs for the new timing parameter right now. |
Forgot to add this file.
| protected void handleRequest(RestRequest request, RestChannel channel, Client client) throws Exception { | ||
| XContentBuilder builder = XContentFactory.contentBuilder(XContentType.JSON); | ||
| try { | ||
| TemplateQueryParser.TemplateContext templateContext = SearchService.getTemplateContext(request.content()); |
There was a problem hiding this comment.
will this work with a client node? I mean I am not sure if all the nodes have all templates. I think you should use the client here to fetch the template.
|
I left some comments, yet I think the rendering functionality is awesome but the custom reload interval I am not sure about. What is the usecase and / or where is |
|
@GaelTadh this has been stalled since 5 month, what's the status? |
|
This PR is very old, most of it got merged with #11570 anyway. Closing. |
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Disk Scripts : Make on disk scripts re-load timing dynamically configurable.
This change adds a new resource watcher level of CUSTOM and allows the addition of custom levels of timing.
This is used by the ScriptService to register the FileWatcher.
Search Templates: Add render endpoint for rendering templates
This commit adds a render endpoint to allow rendering of templates.
Will render
Closes #6821