Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "noop" request breaker a non-dynamic setting #8179

Merged
merged 1 commit into from Oct 22, 2014
Merged

Make "noop" request breaker a non-dynamic setting #8179

merged 1 commit into from Oct 22, 2014

Commits on Oct 22, 2014

  1. Make "noop" request breaker a non-dynamic setting 

    The issue with making it dynamic is that in the event a cluster is
switched from a noop to a concrete implementation, there may be
in-flight requests, once these requests complete we adjust the breaker
with a negative number and trip an assertion.

This also rarely uses noop breakers in InternalTestCluster
    @dakrone
    dakrone committed Oct 22, 2014
    Copy the full SHA
    f7d227e View commit details
    Browse the repository at this point in the history