Analysis: Use ES version of PatternAnalyzer for prebuilt version. #8316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h is not susceptible to default locale issues.
|
FYI: this change was already done in the 5.0 upgrade branch, additionally it has unit tests and so on there. |
|
Closing in favor of the changes on 5.0, and moving fixing the tests to a separate issue (#8492). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch already has a custom PatternAnalyzerProvider to avoid a lowercasing localization issue. But the prebuilt version still used lucene's version. This pulls the ES version out so it can be used in the prebuilt analyzers, and fixes the analysis bwc test to not use text containing characters that could have problems with the old version.