Generate dynamic mappings for empty strings. #8329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
:Search/Mapping
jpountz
force-pushed
the
fix/dynamic_mappings_empty_string
branch
from
ff8e82b
to
c484634
Compare
This will help the exists/missing filters behave as expected in presence of empty strings, as well as when using a default analyzer that would generate tokens for an empty string (uncommon). Close elastic#8198
jpountz
force-pushed
the
fix/dynamic_mappings_empty_string
branch
from
c484634
to
2083ee9
Compare
|
LGTM. |
|
LGTM |
|
Any walk around for filtering out empty string in 1.4.2? "range": { |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help the exists/missing filters behave as expected in presence of
empty strings, as well as when using a default analyzer that would generate
tokens for an empty string (uncommon).
Close #8198