Raise log level on DiskThresholdDecider #8368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having not enough disk space to allocate the shard is worth warning about. Closes elastic#8367
|
@dakrone please take a look |
|
Hi @nik9000 The problem with this is that the allocation deciders can be called hundreds of times per second, which would flood your logs with warnings. See the discussion here: #3637 (comment) I think a better solution would be to warn once every 30 seconds when the low watermark is breached, as we do for the high watermark already: https://github.com/elasticsearch/elasticsearch/pull/8270/files#diff-1b8dca987fbcfb8d8e452d7e29c4d058R139 @dakrone says he'll work on that. thanks |
|
Sounds good.
|
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Nov 7, 2014
Fixes an issue where only absolute bytes were taken into account when kicking off an automatic reroute due to disk usage. Also randomized the tests to use either an absolute value or a percentage so this is tested. Also adds logging for each node over the high and low watermark every time a new cluster info usage is gathered (defaults to every 30 seconds). Related to elastic#8368 Fixes elastic#8367
dakrone
added a commit
that referenced
this pull request
Nov 7, 2014
Fixes an issue where only absolute bytes were taken into account when kicking off an automatic reroute due to disk usage. Also randomized the tests to use either an absolute value or a percentage so this is tested. Also adds logging for each node over the high and low watermark every time a new cluster info usage is gathered (defaults to every 30 seconds). Related to #8368 Fixes #8367
dakrone
added a commit
that referenced
this pull request
Nov 7, 2014
Fixes an issue where only absolute bytes were taken into account when kicking off an automatic reroute due to disk usage. Also randomized the tests to use either an absolute value or a percentage so this is tested. Also adds logging for each node over the high and low watermark every time a new cluster info usage is gathered (defaults to every 30 seconds). Related to #8368 Fixes #8367
dakrone
added a commit
that referenced
this pull request
Nov 13, 2014
Fixes an issue where only absolute bytes were taken into account when kicking off an automatic reroute due to disk usage. Also randomized the tests to use either an absolute value or a percentage so this is tested. Also adds logging for each node over the high and low watermark every time a new cluster info usage is gathered (defaults to every 30 seconds). Related to #8368 Fixes #8367
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Fixes an issue where only absolute bytes were taken into account when kicking off an automatic reroute due to disk usage. Also randomized the tests to use either an absolute value or a percentage so this is tested. Also adds logging for each node over the high and low watermark every time a new cluster info usage is gathered (defaults to every 30 seconds). Related to elastic#8368 Fixes elastic#8367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having not enough disk space to allocate the shard is worth warning about.
Closes #8367