Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ArithmeticException[/ by zero] when parsing a polygon #8475

Merged
merged 4 commits into from Nov 19, 2014
Merged

Fix for ArithmeticException[/ by zero] when parsing a polygon #8475

merged 4 commits into from Nov 19, 2014
+119 −4

Commits on Nov 13, 2014

  1. [GEO] Fix for ArithmeticException[/ by zero] when parsing a "polygon"… 

    … with one pair of coordinates

While this commit is primariy a fix for issue/8433 it adds more rigor to ShapeBuilder for parsing against the GeoJSON specification. Specifically, this adds LinearRing and LineString validity checks as defined in http://geojson.org/geojson-spec.html to ensure valid polygons are specified. The benefit of this fix is to provide a gate check at parse time to avoid any further processing if an invalid GeoJSON is provided.  More parse checks like these will be necessary going forward to ensure full compliance with the GeoJSON specification.

Closes elastic#8433
    @nknize
    nknize committed Nov 13, 2014
    Configuration menu
    Copy the full SHA
    c39ca47 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2014

  1. Correcting coordinate checks on LinearRing and LineString, updating test

    @nknize
    nknize committed Nov 14, 2014
    Configuration menu
    Copy the full SHA
    345c06e View commit details
    Browse the repository at this point in the history

  2. Adding parse gates for valid GeoJSON coordinates. Includes unit tests.

    @nknize
    nknize committed Nov 14, 2014
    Configuration menu
    Copy the full SHA
    4993565 View commit details
    Browse the repository at this point in the history

  3. Updating to throw IllegalArgument exception for null value coordinate… 

    …s. Tests included.
    @nknize
    nknize committed Nov 14, 2014
    Configuration menu
    Copy the full SHA
    0067a0c View commit details
    Browse the repository at this point in the history