Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bloom filter ram usage calculation #8584

Merged
merged 1 commit into from Nov 20, 2014
Merged

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Nov 20, 2014

BloomFilter actually returned the size of the bitset as the
size in bytes so off by factor 8 plus a constant :)

Closes #8564

BloomFilter actually returned the size of the bitset as the
size in bytes so off by factor 8 plus a constant :)

Closes elastic#8564
@mikemccand
Copy link
Contributor

LGTM

@rmuir
Copy link
Contributor

rmuir commented Nov 20, 2014

+1

@s1monw s1monw merged commit 3e1b7c7 into elastic:master Nov 20, 2014
@s1monw s1monw removed the review label Nov 20, 2014
@clintongormley clintongormley changed the title [BLOOM] Fix Bloom filter ram usage calculation Stats: Fix Bloom filter ram usage calculation Nov 25, 2014
@clintongormley clintongormley added the :Data Management/Stats Statistics tracking and retrieval APIs label Mar 19, 2015
@clintongormley clintongormley changed the title Stats: Fix Bloom filter ram usage calculation Fix Bloom filter ram usage calculation Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bloom filter overestimates ram usage by order of magnitude
4 participants