function_score: use query and filter together #8675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if filter and query was defined for function_score, then the filter was silently ignored. Now, if both is defined then function score query wraps this in a filtered_query. closes elastic#8638
| query = Queries.newMatchAllQuery(); | ||
| } | ||
| if (query == null && filter != null) { |
There was a problem hiding this comment.
there can all be else if no?
|
left two comments |
|
Should we raise an error instead of implicitely wrapping into a FilteredQuery? |
|
@jpountz I'm OK with wrapping this in a |
|
No objections, just wanted to make sure we considered this option too. :-) |
|
thanks for the quick review! Addressed all comments. |
|
closed f00b431 |
|
oh. wrong window, sorry |
|
LGTM |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if filter and query was defined for function_score, then the
filter was silently ignored. Now, if both is defined then function score
query wraps this in a filtered_query.
closes #8638