Made the nested, reverse_nested and children aggs ignore unmapped nested fields or unmapped child / parent types.
#8808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I'm wondering if this change should go to 1.4.2 or not (ie. do we consider it a bug fix or an enhancement)? Since the change in behaviour is quite significant, I would lean towards not backporting to 1.4.2? |
|
@jpountz Agreed, lets only make this change in 1.5 and master. |
martijnvg
force-pushed
the
nested_reverse_nested_children_aggs_unmapped
branch
from
5a3f398
to
61d237f
Compare
…ed nested fields or unmapped child / parent types. Closes elastic#8760
martijnvg
force-pushed
the
nested_reverse_nested_children_aggs_unmapped
branch
from
61d237f
to
ca68136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #8760