New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log byte and doc size for slow merges #8855
Conversation
LGTM. One readability comment would be to use |
@@ -117,10 +118,17 @@ protected void doMerge(MergePolicy.OneMerge merge) throws IOException { | |||
totalMergesNumDocs.inc(totalNumDocs); | |||
totalMergesSizeInBytes.inc(totalSizeInBytes); | |||
totalMerges.inc(took); | |||
String message = String.format(Locale.ROOT, | |||
"merge segment %s done: took %s, %.1f MB, %d docs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the [] around values? we should make this consistent with other logs merge segment [%s] done: took [%s], [%.1f MB], [%d] docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I'll add the []s
I just added byte & doc size of the merge when we log it.
Closes #8853