Internal: Add support for sending cluster state using diffs #9220
Conversation
…rialized cluster state
imotov
added
:Core/Infra/Core
| @@ -37,8 +37,6 @@ | |||
| */ | |||
| public class NodesInfoResponse extends NodesOperationResponse<NodeInfo> implements ToXContent { | |||
|
|
|||
| private SettingsFilter settingsFilter; | |||
There was a problem hiding this comment.
I wonder why this was removed?
Changes after the first round of review by @bleskes
| @@ -55,7 +55,7 @@ public ClusterName getClusterName() { | |||
| public void readFrom(StreamInput in) throws IOException { | |||
| super.readFrom(in); | |||
| clusterName = ClusterName.readClusterName(in); | |||
| clusterState = ClusterState.Builder.readFrom(in, null, clusterName); | |||
| clusterState = ClusterState.Builder.readFrom(in, null); | |||
There was a problem hiding this comment.
maybe it's more intuitive to have a readFrom(StreamInput input) that delegates than passing null here?
|
I went over this briefly and I am surprised how brief it is compared to what I expected. Yet, I am kind of overwhelmed by the complexity it adds compared to the previous way of doing it. I personally think this is mainly due to the large hierarchies that are added here like we have tons of impl of this I know this is not an easy change but I think we need to really watch out to not add too much complexity here. |
|
++
|
Closes #6295